Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SynType.MeasureDivide #14148

Merged
merged 7 commits into from
Oct 26, 2022
Merged

Remove SynType.MeasureDivide #14148

merged 7 commits into from
Oct 26, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 19, 2022

I believe SynType.MeasureDivide is no longer being used.
The syntax is represented by SynTupleTypeSegment in SynType.Tuple.
I'm interested to see the results of the CI on this.

@T-Gro T-Gro requested a review from dsyme October 20, 2022 07:35
@T-Gro T-Gro enabled auto-merge (squash) October 20, 2022 07:35
@T-Gro T-Gro requested a review from vzarytovskii October 21, 2022 07:57
@T-Gro
Copy link
Member

T-Gro commented Oct 25, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@nojaf nojaf requested a review from a team as a code owner October 26, 2022 07:13
psfinaki
psfinaki reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@T-Gro T-Gro merged commit c7277a8 into dotnet:main Oct 26, 2022
@nojaf nojaf deleted the remove-measure-divide branch October 26, 2022 12:19
@vzarytovskii vzarytovskii added this to the Backlog milestone Oct 31, 2022
@allisonchou allisonchou mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

@dsyme dsyme Awaiting requested review from dsyme

@vzarytovskii vzarytovskii Awaiting requested review from vzarytovskii

Assignees
No one assigned
Labels
release/17.5
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@nojaf @T-Gro @psfinaki @vzarytovskii